Description

This pull request addresses both performance issues and zIndex issues in 2D infinite scroll mode.

Currently, the execute2DViewportCommands function clones camera.position so that the camera's x and y positions can be modified to enable infinite scrolling (i.e., rendering another copy of the map to the side). At the end of execute2DViewportCommands, the camera's position is reset to the copy that was created earlier, because the camera modifications made were solely for rendering -- the camera is not actually intended to move. However, it appears that copying the previous camera z position (which is not modified in execute2DViewportCommands for infinite scroll rendering) resets changes made in executeCommands to avoid z-fighting:

This pull request fixes this issue by only resetting the x and y values of the camera, rather than the entire position object. This fixes z-fighting reported in #8302 (zIndex Sandcastle):

Before	After

Additionally, this pull request removes an extraneous clone() operation on the frustum. The frustum variable is cloned from the camera on initialization, and thus does not need to be recloned later:

These two changes also resolve some performance issues in 2D infinite scroll mode, for reasons that are not entirely clear to me. See the following screen recordings. In the Before recording, the FPS while panning drops from a steady ~100fps to around ~75fps. In the After recording, the FPS starts substantially higher, around ~140fps, and drops to only ~130fps.

I am not clear on exactly where this performance hit is coming from, but the improvements appear to be even more noticeable on a lower-spec machine (where panning performance goes from ~30fps before the change to a steady ~90fps after the change).

Issue number and link

zIndex Issue: #8302

Likely related performance issue: #5026

Testing plan

I have tested that this fixes both the zIndex and performance issues on a variety of machines using this zIndex Sandcastle.

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code